[$125] Index bug

[jmgasper]

@afrisalyp - I think we may have a bug related to the new indices added, and the git access links.

We saw one report of a user unable to use a Gitlab link, which normally has been working fine. Their user mapping record was never properly added.

We attempted to add it manually, and were unable to because the GithubUsernameIndex was requiring a value.

We need to make sure that the indices aren't causing problems with adding records for new users.

[jmgasper]

Challenge https://www.topcoder.com/challenges/c1083fbb-1c8d-46c5-93f6-685a7ac8e911 has been created for this ticket.

This is an automated message for ghostar2020 via Topcoder X

[jmgasper]

Challenge https://www.topcoder.com/challenges/c1083fbb-1c8d-46c5-93f6-685a7ac8e911 has been assigned to afrisalyp.

This is an automated message for ghostar2020 via Topcoder X

[afrisalyp]

@jmgasper

Sorry just noticed that we haven't test this functionality.

We put connection between topcoderUsername -> github and gitlab account in the same table (UserMapping)

But at some cases, only one connection available (topcoderUsername -> github) or (topcoderUsername -> gitlab).

Since we define indexes on all of the fields, we need to fill them all.

We have three options here.

1. Remove indexes and change query to scan for table UserMapping.
2. Fill not applicable required fields with dummy string.
3. Separate table into two tables (GithubUserMapping and GitlabUserMapping).

Any thoughts on this?

[jmgasper]

Let's split into two tables. That'll make more sense, I think, and will allow us to avoid both dummy data and the removal of indices.

[afrisalyp]

@jmgasper

Sure, thanks.

We will need to migrate the contents of UserMapping table into GithubUserMapping and GitlabUserMapping.
Which one do you prefer?

1. We will create a migration script.
2. We will handle migration seamlessly in runtime. So when the process needs to query but can't find the data, it will query in the old table (UserMapping), if it found, it will be stored in the new tables.

[jmgasper]

Let's do a migration script, thanks. That way we won't have data in two places and a deprecated table sitting around.

[afrisalyp]

@jmgasper

Please do npm run create-tables to create the added tables and npm run migrate-user-mapping to migrate the UserMapping table to the new tables.