fix #45

Author: uttpal

src/common/constants.js

@@ -157,6 +157,10 @@ module.exports = {
           title: 'Your project has a new owner',
           content: (data) => `${data.firstName} ${data.lastName} is now responsible for project <a href="${data.projectUrl}" rel="nofollow">${data.projectName}</a>. Good luck ${data.firstName}.`,
         },
+        ownerAdded: {
+          title: 'Ownership changed',
+          content: (data) => `Your project has a new owner ${data.firstName} ${data.lastName} is now responsible for project Project title. Good luck ${data.firstName}!`,
+        },
       },
     },
     project: {

src/handlers/memberEvents.js

@@ -10,6 +10,7 @@
 const config = require('config');
 const constants = require('../common/constants');
 const util = require('./util');
+const _ = require('lodash');
 
 /**
  * Create notifications from project.member.added events
@@ -28,16 +29,18 @@ function* memberAdded(logger, data) {
       copilot: [],
     },
   };
-
-  if (data.role === constants.memberRoles.customer) {
+  if (data.role === constants.memberRoles.customer && data.isPrimary) {
+    topic = constants.notifications.discourse.teamMembers.ownerAdded;
+  } else if (data.role === constants.memberRoles.customer) {
     topic = constants.notifications.discourse.teamMembers.added;
   } else if (data.role === constants.memberRoles.manager) {
     topic = constants.notifications.discourse.teamMembers.managerJoined;
   } else if (data.role === constants.memberRoles.copilot) {
     topic = constants.notifications.discourse.teamMembers.copilotJoined;
     // Notify project claimed
     const slackNotification = util.buildSlackNotification(
-      { project,
+      {
+        project,
         firstName: addedMember.firstName,
         lastName: addedMember.lastName,
       },

src/test/app.test.js

@@ -27,6 +27,7 @@ const sampleEvents = {
   updatedReviewedAnotherStatus: require('./data/events.updated.reviewed.anotherStatus.json'),
   updatedReviewedSameStatus: require('./data/events.updated.reviewed.sameStatus.json'),
   memberAddedTeamMember: require('./data/events.memberAdded.teamMember.json'),
+  memberAddedOwner: require('./data/events.memberAdded.owner.json'),
   memberAddedManager: require('./data/events.memberAdded.manager.json'),
   memberAddedCopilot: require('./data/events.memberAdded.copilot.json'),
   memberRemovedLeft: require('./data/events.memberRemoved.left.json'),
@@ -341,6 +342,18 @@ describe('app', () => {
   });
 
   describe('`project.member.added` event', () => {
+    it('should create `Project.Member.ownerAdded` notification', (done) => {
+      sendTestEvent(sampleEvents.memberAddedOwner, 'project.member.added');
+      setTimeout(() => {
+        const expectedTitle = 'Ownership changed';
+        const expectedBody = 'Your project has a new owner F_user L_user is now responsible for project Project title. Good luck F_user!';
+        const params = spy.lastCall.args;
+        assert.equal(params[2], expectedTitle);
+        assert.equal(params[3], expectedBody);
+        done();
+      }, testTimeout);
+    });
+
     it('should create `Project.Member.TeamMemberAdded` notification', (done) => {
       sendTestEvent(sampleEvents.memberAddedTeamMember, 'project.member.added');
       setTimeout(() => {

src/test/data/events.memberAdded.owner.json

@@ -0,0 +1,11 @@
+{
+  "id": 1185,
+  "userId": 40051331,
+  "role": "customer",
+  "isPrimary": true,
+  "createdAt": "2016-11-04T03:57:57.000Z",
+  "updatedAt": "2016-11-04T03:57:57.000Z",
+  "createdBy": 40152856,
+  "updatedBy": 40152856,
+  "projectId": 1
+}

src/test/data/events.memberAdded.teamMember.json

@@ -2,7 +2,7 @@
   "id": 1185,
   "userId": 40051331,
   "role": "customer",
-  "isPrimary": true,
+  "isPrimary": false,
   "createdAt": "2016-11-04T03:57:57.000Z",
   "updatedAt": "2016-11-04T03:57:57.000Z",
   "createdBy": 40152856,