Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit affcad6

Browse files
committed
fix #63
1 parent 80e2534 commit affcad6

File tree

2 files changed

+43
-9
lines changed

2 files changed

+43
-9
lines changed

src/common/constants.js

Lines changed: 31 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030
fallback: 'A project is ready to be reviewed.',
3131
title: _.get(data, 'project.name', ''),
3232
title_link: `https://connect.${config.get('AUTH_DOMAIN')}/projects/${data.project.id}/`,
33-
text: _.truncate(_.get(data, 'project.description', ''), {length: 200, separator: /,? +.,/ }),
33+
text: _.truncate(_.get(data, 'project.description', ''), { length: 200, separator: /,? +.,/ }),
3434
ts: (new Date(_.get(data, 'project.updatedAt', null))).getTime() / 1000,
3535
fields: [
3636
{
@@ -40,7 +40,12 @@ module.exports = {
4040
},
4141
{
4242
title: 'Owner',
43-
value: `${_.get(data, 'owner.firstName', '')} ${_.get(data, 'owner.lastName', '')}` ,
43+
value: `${_.get(data, 'owner.firstName', '')} ${_.get(data, 'owner.lastName', '')}`,
44+
short: false,
45+
},
46+
{
47+
title: 'Project Type',
48+
value: data.project.type,
4449
short: false,
4550
},
4651
],
@@ -54,9 +59,15 @@ module.exports = {
5459
fallback: 'A project has been reviewed and needs a copilot. Please check it out and claim it.',
5560
title: _.get(data, 'project.name', ''),
5661
title_link: `https://connect.${config.get('AUTH_DOMAIN')}/projects/${data.project.id}/`,
57-
text: _.truncate(_.get(data, 'project.description', ''), {length: 200, separator: /,? +.,/ }),
62+
text: _.truncate(_.get(data, 'project.description', ''), { length: 200, separator: /,? +.,/ }),
5863
ts: (new Date(_.get(data, 'project.updatedAt', null))).getTime() / 1000,
59-
fields: []
64+
fields: [
65+
{
66+
title: 'Project Type',
67+
value: data.project.type,
68+
short: false,
69+
},
70+
]
6071
}
6172
},
6273
projectUnclaimedReposted: (data) => {
@@ -67,9 +78,15 @@ module.exports = {
6778
fallback: 'We\'re still looking for a copilot for a reviewed project. Please check it out and claim it.',
6879
title: _.get(data, 'project.name', ''),
6980
title_link: `https://connect.${config.get('AUTH_DOMAIN')}/projects/${data.project.id}/`,
70-
text: _.truncate(_.get(data, 'project.description', ''), {length: 200, separator: /,? +.,/ }),
81+
text: _.truncate(_.get(data, 'project.description', ''), { length: 200, separator: /,? +.,/ }),
7182
ts: (new Date(_.get(data, 'project.updatedAt', null))).getTime() / 1000,
72-
fields: []
83+
fields: [
84+
{
85+
title: 'Project Type',
86+
value: data.project.type,
87+
short: false,
88+
},
89+
]
7390
}
7491
},
7592
projectClaimed: (data) => {
@@ -80,9 +97,15 @@ module.exports = {
8097
fallback: `${data.firstName} ${data.lastName} has claimed a project. Welcome to the team!`,
8198
title: _.get(data, 'project.name', ''),
8299
title_link: `https://connect.${config.get('AUTH_DOMAIN')}/projects/${data.project.id}/`,
83-
text: _.truncate(_.get(data, 'project.description', ''), {length: 200, separator: /,? +.,/ }),
100+
text: _.truncate(_.get(data, 'project.description', ''), { length: 200, separator: /,? +.,/ }),
84101
ts: (new Date(_.get(data, 'project.updatedAt', null))).getTime() / 1000,
85-
fields: []
102+
fields: [
103+
{
104+
title: 'Project Type',
105+
value: data.project.type,
106+
short: false,
107+
},
108+
]
86109
}
87110
},
88111
},

src/test/app.test.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,13 @@ const expectedSlackNotficationBase = {
5555
title: "test",
5656
title_link: "https://connect.topcoder-dev.com/projects/1/",
5757
text: "test",
58-
fields: [],
58+
fields: [
59+
{
60+
short: false,
61+
title: 'Project Type',
62+
value: 'visual_design',
63+
},
64+
],
5965
footer: "Topcoder",
6066
footer_icon: "https://emoji.slack-edge.com/T03R80JP7/topcoder/7c68acd90a6b6d77.png",
6167
ts: 1478304000,
@@ -89,6 +95,11 @@ _.extend(expectedManagerSlackNotification.attachments[0], {
8995
fields: [
9096
{ title: 'Ref Code', value: '', short: false },
9197
{ title: 'Owner', value: 'F_user L_user', short: false },
98+
{
99+
short: false,
100+
title: 'Project Type',
101+
value: 'visual_design',
102+
},
92103
]
93104
})
94105

0 commit comments

Comments
 (0)