Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

feat: add tui editor #109

Merged
merged 2 commits into from
Feb 23, 2021
Merged

feat: add tui editor #109

merged 2 commits into from
Feb 23, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 23, 2021 •
edited by maxceem
Loading

Issue #100

@yoution
Copy link
Contributor Author

yoution commented Feb 23, 2021

@maxceem please review

maxceem
maxceem suggested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution it works and looks great.

I have a coupe code improvement suggestion, could you please check them out, would they work?

@yoution yoution requested a review from maxceem February 23, 2021 11:59
maxceem
maxceem approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update @yoution. All looks good now.

@maxceem maxceem merged commit ced2d16 into topcoder-archive:dev Feb 23, 2021
@yoution yoution deleted the feature/tuieditor branch June 22, 2021 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem