[functional] if no candidate available for review, still the status shows as 'candidate available for review' on the team/job page

[swap12875]

Description:

if no candidate available for review, still the status shows as 'candidate available for review' on the team/job page

---

Steps to reproduce:

1. Goto the https://platform.topcoder-dev.com/taas/myteams/17258
2. click on the 'Review candidate' button.
3. select/declined all available candidate for the job

--

video :

available.to.review.mp4

---

Actual result:

if no candidate available for review, still the status shows the as 'candidate available for review' on the team/job page

---

Expected result:

The availability status should update when the user select/declined any interview of the candidate and should not show 'candidate available for review'

---

Device/Browser Info

Device details: Laptop/Windows 10 pro

Browser : Chrome [Version 89.0.4389.90 (Official Build) (64-bit)]

[cagdas001]

The reason for this might be the position is manually created with in-review status. The default status on creation is sourcing, but admin role users have the right to change this value.

With regular flow, the position should be created with sourcing status first. Then, once a job candidate is created for this position, the status gets updated to in-review in the backend. So I think this should not be an issue as long as you follow the regular flow.

Any further action is needed? @nikolay83 @urwithat

To prevent confusion, maybe we can show "In Review" in the status column, with no button (Review Candidates), for the positions with the status in-review but has no actual candidates at the time. And, for the positions with really available candidates, we can show the current "Candidates Available for Review" text, with the "Review Candidates" button next to it.

[SathyaJayabal]

@cagdas001 , what they mean is when the customer has either selected or declined all candidates, the status of the job is still in in-review and we show the "Review candidate" button. When they click on the button there is no action they can take as all the candidates are in the selected/declined tabs. It doesn't necessarily involve manual updating of the job status.

The status of the job is updated to assigned, only after all job positions are filled (RB created and candidates placed). Until then the status is in-review and review candidates button is available. This is the current flow.

cc @nikolay83 @urwithat @wdprice

[cagdas001]

@SathyaJayabal Even though you select/decline all candidates, I guess it might still be possible for future candidates to appear on the "To Review" list? (for e.g. if someone applies to the job after you selected/declined all candidates) If this is a possible case, then selecting/declining all candidates should not be enough to update the status to assigned I think.

However, if you're getting the applications while only in the sourcing status, and, if we can safely assume that no one can still apply while in the in-review status, then yes, we may update the status to assigned when all candidates are either selected or declined.

The status of the job is updated to assigned, only after all job positions are filled (RB created and candidates placed). Until then the status is in-review and review candidates button is available. This is the current flow.

I don't see this flow in the current implementation. The job status stays in-review and there's no further logic to update it depending on other candidate conditions like you said. There's one place doing a similar thing, but it takes resource booking status into consideration, not the candidate status.

https://github.com/topcoder-platform/taas-apis/blob/a4dabc4b4f6b5343505e13fa0868a049b3218860/src/eventHandlers/ResourceBookingEventHandler.js#L71-L127

And, one thing to note, the candidate status gets updated to selected when you hit the "Select" button. It's doesn't get updated to placed

[nikolay83]

@SathyaJayabal @urwithat @wdprice

1. So is it possible to add new candidates when the status is in-review?
2. If p.1 is yes Then let's display the "No candidates for review at the moment" status and hide the "Review candidates" button (when all the candidates are either selected or declined).
3. If p.1 is no, then let's move it to the next status automatically once all the candidates are either selected or declined.