[$70] Editing a JOB is not syncing to RCRM

[SathyaJayabal]

1. Create a job in taas
2. Check that the job appears in RCRM
3. edit the job name/description in taas
4. Check job details on RCRM

Actual: The updates made on the Taas app are not reflected in RCRM. Further more, any updates to the job candidates statues in either RCRM or Taas are not synced.

Expected:The updates made on the Taas app must be reflected in RCRM. Further more, there should not be any effect on the Job Candidate status syncs

Note: This issue is present only on DEV.

@nkumar-topcoder confirmed that this is good on PROD

[nkumar-topcoder]

@nikolay83
there's is a mixup of external id here.
https://github.com/topcoder-platform/taas-app/blob/dev/src/routes/JobForm/index.jsx#L67.

Please note - that externalID are there only for 2 tables - job.externalid and jobcandidate.externalid and Only used for syncing to recruit crm.

also inform the submitter to check for all the places where externalid is set to userid. (including other repos (taas-apis, taas-es-processor)), It should never be set to userid. Externalid’s are only for RCRM.

additional Info
rcrm.jobid (job slug) = taas.job.externalid
rcrm.jobcandidateid(job cadndidate slug) = taas.jobcandidate.externalid

[nikolay83]

@cagdas001 instead id external ID please use her UUID from v5/users

@cagdas001 please ignore above, we don't assign anything to externalId. leave it as it was earlier. Please check the current prod code.
https://github.com/topcoder-platform/taas-app/blob/master/src/routes/JobForm/index.jsx#L67 and keep same. But, retain the changes made for placed in-place of assigned.

[nkumar-topcoder]

@cagdas001 also check if you made any other externalid assigned to userid any where else or taas-apis or taas-es-process compare with prod and retain as it. externalId was never assinged with userid in any of existing deployment.

if it's not assigned anywhere else, i guess it's simple change of removing the userid assignment.

[cagdas001]

OK, looks like we get the purpose of externalId wrong. We were using the job.externalId to find the customer user/email. Anyway, as the customer email is now already coming from the UI, we don't need such a thing at all, it's now redundant and can be removed.

However, the externalId was already being used for finding users before. There are already some places using it in this way.

https://github.com/topcoder-platform/taas-apis/blob/0b57894a418bbdac836c181a08cf541771f65d76/src/common/helper.js#L676-L716

[SathyaJayabal]

Verified.

[SathyaJayabal]

verified on prod.