Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Compacted WP table, added WP data reload after payments' BA update #91

Conversation

MadOPcode
Copy link
Contributor

@MadOPcode MadOPcode commented Aug 10, 2021

Implements #90, #92, #93.
Added WP data reload after payments' BA update to check whether all BAs were updated.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tooltip for the Team Name for the first row now is getting shown under the team name, instead of on top of it, see screenshot https://monosnap.com/file/6t2ZvI3b5mKPJAPNX1kLfGU3gHdNAb

  2. We don't have to reload work period because in the response of "/work-period-payments/bulk" we already return info about which BA was updated successfully and which wasn't like this https://monosnap.com/file/kHMG53DrXYVbDWg717FVkbCfCqhiOn. The response of create/update requests always return up to date info, unlike if we get data immediately after that.

  3. We also have the same kind of issue in TaaS App and add such an artificial delay https://github.com/topcoder-platform/taas-app/blob/dev/src/constants/index.js#L35-L38. Let's also create a similar constant which we would use in all the places instead of hardcoding 3000.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadOPcode works good for me as per local testing, merging to pass to QA.

@maxceem maxceem merged commit e5e67b2 into topcoder-archive:feature/payment-updates Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants