legacy payment details missing

[ajefts]

1. The payment_desc is not getting populated.
2. The total payment is getting set to double the gross payment. Here is an example: https://community.topcoder.com/PactsInternalServlet?module=ViewPayment&payment_id=712618 I'm not sure if this happened because there was both a copilot + winner payment set for the user on this task (5+5). From what I can see, I think the processor ended up creating 1 payment instead of 2 separate payments for the challenge: 87affffc-6ec5-4c16-bcd5-c78a4587d78f.
3. Set the jira_issue_id to the challenge uuid OR add a new column to payment_detail to store the new challenge uuid.

[ajefts]

@sachin-maheshwari Can you take a look at this one please?

[sachin-maheshwari]

@ajefts i'll check today.

[sachin-maheshwari]

@ajefts this is the latest records inserted in DB in DEV (through WM). Please have a look.

[sachin-maheshwari]

@ajefts @rootelement root cause for "copilot" payment record was not inserted - due to copilot member detail was missing in the challenge. Example - https://api.topcoder.com/v5/resources?challengeId=87affffc-6ec5-4c16-bcd5-c78a4587d78f&roleId=cfe12b3f-2a24-4639-9d8b-ec86726f76bd

Please suggest.

[rootelement]

Ah, that's my fault. Sorry! I will fix my postman.

…

On Wed, Mar 3, 2021 at 6:33 AM sachin-maheshwari ***@***.***> wrote: @ajefts <https://github.com/ajefts> @rootelement <https://github.com/rootelement> root cause for "copilot" payment record was not inserted - due to copilot member detail was missing in the challenge. Example - https://api.topcoder.com/v5/resources?challengeId=87affffc-6ec5-4c16-bcd5-c78a4587d78f&roleId=cfe12b3f-2a24-4639-9d8b-ec86726f76bd Please suggest. [image: Screenshot 2021-03-03 at 4 55 36 PM] <https://user-images.githubusercontent.com/6467888/109799507-237ccf80-7c42-11eb-93a5-b7349aaf9399.png> [image: Screenshot 2021-03-03 at 5 01 25 PM] <https://user-images.githubusercontent.com/6467888/109799526-27a8ed00-7c42-11eb-9249-3205e532d56c.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJGMXHXRM7Q23PVKONCL5TTBYM7DANCNFSM4YPSB3JQ> .

-- James Cori Lead Software Engineer jcori@topcoder.com / 413.961.9044 / @jamesmcori <https://twitter.com/jamesmcori> <cbonner@topcoder.com>www.topcoder.com <http://topcoder.com/> / Topcoder Blog: topcoder.com/blog / twitter: @topcoder <https://twitter.com/topcoder>201 S Capitol Ave, Indianapolis, IN 46225

[sachin-maheshwari]

@ajefts I have already deployed my changes on PROD as suggested. Can you please verify one more time ? CC: @rootelement

[ajefts]

@sachin-maheshwari For the payments, it looks like you're adding the 2 separate payment amounts and calculating the "Total Amount". We should be treating these as 2 completely independent and separate payments. So, the gross amount and total should be the same. Does that make sense?

[sachin-maheshwari]

@ajefts but i am seeing in prod database, in some cases "gross_amount" and "total_amount" are different. And same i am following in payment-processor 😄. "gross_amount" is looking always same as "net_amount".

[ajefts]

@sachin-maheshwari I think you're only seeing those cases in prod when the payments are split into multiple installments. You'll see a single prize on the challenge that the system is splitting into 2 installments (75%/25%) where the total amount is the sum of the gross amounts of the 2 installments.

HOWEVER, for these new payments that we're creating we are NOT splitting them into installments. There should be 1 record per task winner payment and 1 record per copilot payment.

Does that make sense?

[sachin-maheshwari]

@ajefts I corrected the condition - now getting this on DEV. Now fine ?

https://www.topcoder-dev.com/challenges/e5b1c67e-e952-4ef8-9bb2-c5af1d89cd81

[ajefts]

@sachin-maheshwari That looks correct. Thanks.