Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Set forumId to 0 in the DB if forum is not created #531

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Set forumId to 0 in the DB if forum is not created #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ...acade/src/java/main/com/topcoder/service/facade/contest/ejb/ContestServiceFacadeBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4061,7 +4061,6 @@ else if (isDevContest) {
} else {
if(isPrivateProject(contest)) { // no forum to be created for private tasks
logger.debug("Skip forum creation for private task: "+assetDTO.getName());
forumId = -1;
} else {
if (!isStudio(contest)) {
// software contest
Expand Down Expand Up @@ -4224,10 +4223,8 @@ else if (isDevContest) {
// "0");
// }

if (forumId > 0) {
contest.getProjectHeader().setProperty(ProjectPropertyType.DEVELOPER_FORUM_ID_PROJECT_PROPERTY_KEY,
contest.getProjectHeader().setProperty(ProjectPropertyType.DEVELOPER_FORUM_ID_PROJECT_PROPERTY_KEY,
String.valueOf(forumId));
}

contest.getProjectPhases().setStartDate(getDate(productionDate));
}
Expand Down Expand Up @@ -5988,7 +5985,7 @@ private long createStudioForum(String name, long userId) {
logger.error("*** Could not create a studio forum for " + name);
logger.error(e);
}
return -1;
return 0;
}

/**
Expand Down Expand Up @@ -6036,7 +6033,7 @@ public long createForum(TCSubject tcSubject, AssetDTO asset, long userId, long p
logger.error("*** Could not create a forum for " + asset.getName());
logger.error(e);

return forumId;
return 0;
}
}

Expand Down Expand Up @@ -7759,10 +7756,8 @@ else if (autoDevCreating && isDevContest) {
dto.getForum().setCompVersion(null);
}

if (forumId > 0) {
contest.getProjectHeader().setProperty(ProjectPropertyType.DEVELOPER_FORUM_ID_PROJECT_PROPERTY_KEY,
contest.getProjectHeader().setProperty(ProjectPropertyType.DEVELOPER_FORUM_ID_PROJECT_PROPERTY_KEY,
String.valueOf(forumId));
}

contest.setStartDate(getDate(startDate));
// 3.create the project
Expand Down