Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

TC WEBSITE - MARATHON MATCH UPDATE #20

Merged
merged 2 commits into from
Jun 5, 2017

Conversation

liuliquan
Copy link
Contributor

No description provided.

Copy link
Collaborator

@sah2ed sah2ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuliquan

Nice work. I posted a review of small changes that need to be made to the PR before I can merge.

@@ -77,10 +89,25 @@ You can now try the following pages:
TC WAR:
* Open https://local.tc.cloud.topcoder.com/tc?module=MyHome, the page is like: http://take.ms/TYP9F
* Open https://local.tc.cloud.topcoder.com/tc?module=EditTheme, change to use old theme, the page is like: http://take.ms/efKBr
* Open https://local.tc.cloud.topcoder.com/tc?module=ActiveContests&pt=39 (code active contests), the page is like: http://take.ms/RxSWZ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuliquan
any reason why this was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old ActiveContests page is redirected to challenges list page, see topcoder-archive/tc-website@1ac7b2a

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuliquan
OK but the docker image is used for development/testing. Better to leave it since it wasn't in scope of changes to the MM side of the website.

@@ -15,10 +15,12 @@ cp -f /root/files/TC.prod.ldap.keystore $JBOSS_HOME/bin
cp -f /root/files/resources/paymentRanges.xml $JBOSS_HOME/server/all/conf

# init code
cp -f /root/files/build_mm.xml /root/tc-platform/tc-website
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuliquan
Instead of adding a modified copy of build_mm.xml to the docker image, better to submit a pull request against the tc-website repo for that file.

So please remove the cp command and the copy of build_mm.xml included with this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about that the build_mm.xml is stilled used for VM deployment, changing it in tc-website repo would possibly break the VM deployment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, VM deployment still uses svn instead of git to set up the environment; besides the changes are to the dev branch which the PM could cherry pick before merging into master.

@liuliquan
Copy link
Contributor Author

Updated. Pull request for tc-website repo is topcoder-archive/tc-website#8

@sah2ed sah2ed merged commit 4e8cb70 into topcoder-archive:master Jun 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants