-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I posted a review of small changes that need to be made to the PR before I can merge.
docker/tc-website/README.md
Outdated
@@ -77,10 +89,25 @@ You can now try the following pages: | |||
TC WAR: | |||
* Open https://local.tc.cloud.topcoder.com/tc?module=MyHome, the page is like: http://take.ms/TYP9F | |||
* Open https://local.tc.cloud.topcoder.com/tc?module=EditTheme, change to use old theme, the page is like: http://take.ms/efKBr | |||
* Open https://local.tc.cloud.topcoder.com/tc?module=ActiveContests&pt=39 (code active contests), the page is like: http://take.ms/RxSWZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuliquan
any reason why this was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old ActiveContests page is redirected to challenges list page, see topcoder-archive/tc-website@1ac7b2a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuliquan
OK but the docker image is used for development/testing. Better to leave it since it wasn't in scope of changes to the MM side of the website.
@@ -15,10 +15,12 @@ cp -f /root/files/TC.prod.ldap.keystore $JBOSS_HOME/bin | |||
cp -f /root/files/resources/paymentRanges.xml $JBOSS_HOME/server/all/conf | |||
|
|||
# init code | |||
cp -f /root/files/build_mm.xml /root/tc-platform/tc-website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuliquan
Instead of adding a modified copy of build_mm.xml
to the docker image, better to submit a pull request against the tc-website
repo for that file.
So please remove the cp
command and the copy of build_mm.xml
included with this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about that the build_mm.xml is stilled used for VM deployment, changing it in tc-website repo would possibly break the VM deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, VM deployment still uses svn instead of git to set up the environment; besides the changes are to the dev
branch which the PM could cherry pick before merging into master
.
Updated. Pull request for tc-website repo is topcoder-archive/tc-website#8 |
No description provided.