Skip to content

Add AsciiString::insert_str #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2022
Merged

Add AsciiString::insert_str #82

merged 3 commits into from
May 31, 2022

Conversation

PatrickNorton
Copy link
Contributor

At the moment, AsciiString has push, insert, and push_str methods, but no insert_str.

@tomprogrammer
Copy link
Owner

This is a useful addition, thanks!
Only the documentation of the panic behavior is missing, which is identical to String::insert_str.

tomprogrammer
tomprogrammer approved these changes May 31, 2022
View reviewed changes
Copy link
Owner

@tomprogrammer tomprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomprogrammer tomprogrammer merged commit 43e4d69 into tomprogrammer:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomprogrammer tomprogrammer tomprogrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickNorton @tomprogrammer