Adding Plugin System

[joseph-flinn]

Adding most of the logic for the Plugin System from #530. I have done some initial manual testing and it seems to be working.

Design Decisions:

• All plugin methods run after their tmuxp config counter parts (ie. the global before_script in the tmuxp config will run before anything in the plugin.before_script method)
• Require list type for plugins even if only a single plugin
• Assuming that the plugin.on_window_create method is referring to when tmuxp is creating new windows versus the user creating a new window in tmux
• Assuming that the plugin.after_window_finished method is referring to after the window is done being setup versus when the tmux user closes the window

Currently missing:

• updated unit tests
• updated documentation

[codecov]

Codecov Report

Merging #628 (ceb7b6b) into master (888b2b3) will increase coverage by 2.06%.
The diff coverage is 92.13%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   73.53%   75.60%   +2.06%     
==========================================
  Files           7        8       +1     
  Lines        1043     1123      +80     
  Branches      268      283      +15     
==========================================
+ Hits          767      849      +82     
+ Misses        202      198       -4     
- Partials       74       76       +2     

Impacted Files	Coverage Δ
tmuxp/config.py	85.94% <66.66%> (-0.24%)	⬇️
tmuxp/cli.py	72.20% <87.50%> (+2.55%)	⬆️
tmuxp/plugin.py	95.34% <95.34%> (ø)
tmuxp/exc.py	95.83% <100.00%> (+0.59%)	⬆️
tmuxp/workspacebuilder.py	89.08% <100.00%> (+1.65%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888b2b3...ceb7b6b. Read the comment docs.

[tony]

@joseph-flinn Try rebasing (I fixed an issue with poetry), running poetry install and then make black isort

[tony]

Lets aim to get this in the next release (and last Python 2.7 release)

This will assure packaged versions of tmuxp on BSD/Linux and systems using python 2.7 have a plugin system.

[joseph-flinn]

Note: The bump in version is required for the extensive testing of the plugin system. The test plugins all depend on tmuxp version 1.6.0 (I believe this is the next release that will contain this feature?)

[tony]

Note: The bump in version is required for the extensive testing of the plugin system. The test plugins all depend on tmuxp version 1.6.0 (I believe this is the next release that will contain this feature?)

Yes, this version bump and the constraint seems appropriate.

[tony]

@joseph-flinn Can you rebase this? (I know from email you're not around today)

[tony]

@joseph-flinn Can you try rebasing instead of merge? e.g. git pull --rebase origin master + git push --force-with-lease ?

[joseph-flinn]

@joseph-flinn Can you try rebasing instead of merge? e.g. git pull --rebase origin master + git push --force-with-lease ?

Whoops, yep. I thought I did the rebase instead of the merge. I don't think I finished the complete mental context switch on Sunday

[joseph-flinn]

Oh, I just remembered that I used the rebase on github.com instead of doing it locally. I guess I won't do that again.

[tony]

@joseph-flinn technically the command (e.g. git pull origin master --autostash) depends on what tmuxp-python/tmuxp is set to

Since I don't know what your remotes are named, here is what it'd be if tmux-python and joseph-flinn are set:

git remote add tmux-python git+ssh://git@github.com/tmux-python/tmuxp.git
git remote add joseph-flinn git+ssh://git@github.com/joseph-flinn/tmuxp.git

Then:
git pull tmuxp-python master --autostash
git push --force-with-lease -u joseph-flinn plugin-system

[tony]

@joseph-flinn Nice! You pushed it seconds after I wrote that, I guess you figured it out before! 😊

[joseph-flinn]

Yeah, that merge was my bad. I tried "resolving the conflicts" through github.com last weekend instead of doing it locally and must of have hit merge instead rebase + merge.

[tony]

@joseph-flinn https://tmuxp.git-pull.com/history.html#tmuxp-1-6-0-2020-11-06

You can rebase again, there's a conflict though (tmuxp/cli.py)

Let's aim to get this in tomorrow (Sunday latest)

Once its in master we will be able to dogfood it on our local machines

[joseph-flinn]

Sounds good. I'm planning on working on it most of tomorrow.

…

On Fri, Nov 6, 2020, 18:25 Tony Narlock ***@***.***> wrote: @joseph-flinn <https://github.com/joseph-flinn> https://tmuxp.git-pull.com/history.html#tmuxp-1-6-0-2020-11-06 You can rebase again, there's a conflict Let's aim to get this in tomorrow (Sunday latest) Once its in master we will be able to dogfood it on our local machines — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#628 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN5KNNNSBWVSB4OFVBHDZEDSOSVZZANCNFSM4QP44Z7Q> .

[tony]

@joseph-flinn If you'd like to rebase this you can

I will try to merge this in this afternoon/evening/tomorrow

[tony]

@joseph-flinn

It's live :)

https://pypi.org/project/tmuxp/1.7.0/

https://tmuxp.git-pull.com/history.html#tmuxp-1-7-0-2021-01-09