Add --combine flag to "load" #407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tony To be honest, I stopped using my fork a while ago and found other ways to solve my problem. I don't think it makes sense to merge it because it lacks tests and is a pretty rough implementation... |
|
@moser no problem at all! Thank you for the PR and for following up, sorry for the delay getting around to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
the implementation works for my simple use case but probably needs more thought & some tests. Please treat this rather as a proposal of an idea than a mergable PR.
My use case: I sometimes work just on my laptop screen, sometimes I have an external screen. Depending on the situation I would like to start some tmux windows within the same or in two different sessions. I thus created two tmuxp config files. In the single-screen case I would like to combine the files into one config and start it as one session.
I added the "--combine" flag which takes all the given configs, combines them in a temporary config file and loads that one.
What do you think of the idea? If you think it is worthwhile, I will add tests and try to make the config merge bulletproof. If you don't, I will just use my fork and save the effort of making it usable for everyone :-)
Cheers,
Martin