Skip to content

Update TMUX_MAX_VERSION, add 3.3a to CI #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Update TMUX_MAX_VERSION, add 3.3a to CI #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd4d95e
chore: Bump TMUX_MAX_VERSION 2.4 -> 3.3
tony Jul 31, 2022
71f66e6
ci(tests): Add tests for tmux 3.3a
tony Jul 31, 2022
1697491
test(allows_next_version): Update to check for next release
tony Jul 31, 2022
9e115cc
docs(CHANGES): Note 3.3a support in #387
tony Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
python-version: ["3.7", "3.10"]
tmux-version: ["2.6", "2.7", "2.8", "3.0a", "3.1b", "3.2a", "master"]
tmux-version: ["2.6", "2.7", "2.8", "3.0a", "3.1b", "3.2a", "3.3a", "master"]
steps:
- uses: actions/checkout@v3

Expand Down
7 changes: 7 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ $ pip install --user --upgrade --pre libtmux
## Compatibility

- Brought back python 3.7 and 3.8 support ({issue}`375`)
- Support for tmux 3.3a

- Add to CI
- Bump `TMUX_MAX_VERSION` from 2.4 -> 3.3

_2.4 to 3.3a already worked, this is just the constant
being updated._

### Development

Expand Down
2 changes: 1 addition & 1 deletion libtmux/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
TMUX_MIN_VERSION = "1.8"

#: Most recent version of tmux supported
TMUX_MAX_VERSION = "2.4"
TMUX_MAX_VERSION = "3.3"

SessionDict = t.Dict[str, t.Any]
WindowDict = t.Dict[str, t.Any]
Expand Down
6 changes: 4 additions & 2 deletions tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ class Hi:


def test_allows_next_version(monkeypatch):
TMUX_NEXT_VERSION = str(float(TMUX_MAX_VERSION) + 0.1)

def mock_tmux_cmd(param):
class Hi:
stdout = ["tmux next-2.9"]
stdout = [f"tmux next-{TMUX_NEXT_VERSION}"]
stderr = None

return Hi()
Expand All @@ -58,7 +60,7 @@ class Hi:
assert has_minimum_version()
assert has_gte_version(TMUX_MIN_VERSION)
assert has_gt_version(TMUX_MAX_VERSION), "Greater than the max-supported version"
assert "2.9" == get_version()
assert TMUX_NEXT_VERSION == get_version()


def test_get_version_openbsd(monkeypatch):
Expand Down