Open
Description
Problem
Waiter
(test_waiter
) flakes a lot.
- Wait / poll / until condition #373
- [Reverted] Waiter 0.1 #582
- Use waiter 2.0 #583
- Waiter v3.0: Requirements #584
Proposal
For cases like Waiter
, may we need an object to simulate shell responses perfectly for the sake of testing correct behavior of test_waiter.py
We're testing the correct behavior of Waiter
In this case, we want to be sure that in various instances, including simulated ones that are exact to real tmux use cases, waiter behaves as designed.
We want correct mocks
Examine mocking of subprocess
responses. In the same way responses
mocks requests
, this would "tap in" at a low level, while also ensuring our existing tests using real tmux still work without any additional effort.
Maybe also permit real tests
Perhaps also allow e2e tests that use real tmux sessions in the backend too
We don't want to lose benefit of testing against real world scenarios:
- Existing fuzziness cause by environments, different shells
- Shell updates, OS updates
- Tmux updates
Metadata
Metadata
Assignees
Labels
No labels