improve handling of tokens ending with braces #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Tokens may contain any character, including a
}
at its end. The current parser to detect tokens greedily picks up the sequence}}
, which does not include any number of trailing}
which would actually end the token. For example, given{{{ a }}}
, the parser would detect the token as{ a
, and leave a trailing}
on the line, when the actual token is{ a }
.This PR modifies our regex so that we include any number of
}
characters greedily before our final}}
that closes the token, so that we force the final}}
as our token closure. This looks like it handles both examples given in #184 as expected, and a quick look did not show any pages as looking abnormal.