Skip to content

add the option to simply print the md file #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

dadav
Copy link
Contributor

@dadav dadav commented Oct 12, 2021

See #167

Copy link
Collaborator

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Code looks fine, though one lint error to take care of.

Would you also be able to add a testcase to tests/test_tldr.py that essentially duplicates test_whole_page, but just checking that the stdout output matches the contents of tests/data/gem.md?

@dadav
Copy link
Contributor Author

dadav commented Oct 12, 2021

Thanks for the PR! Code looks fine, though one lint error to take care of.

Would you also be able to add a testcase to tests/test_tldr.py that essentially duplicates test_whole_page, but just checking that the stdout output matches the contents of tests/data/gem.md?

ok

@dadav dadav requested a review from MasterOdin October 12, 2021 19:43
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks.

@dadav dadav requested a review from MasterOdin October 14, 2021 07:16
@MasterOdin MasterOdin merged commit 67e52a9 into tldr-pages:main Oct 14, 2021
@CleanMachine1
Copy link
Member

@MasterOdin Do these changes not warrant the creation of a new release, since otherwise these features don't get put into package managers.

I'd like to see these in Arch Linux ASAP

@MasterOdin
Copy link
Collaborator

MasterOdin commented Oct 14, 2021

Yes, I was planning on putting together a 2.1.0 release with this PR, and the other commits that had been made since 2.0, sometime in the next few days as my time permitted.

@CleanMachine1
Copy link
Member

Good to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants