-
-
Notifications
You must be signed in to change notification settings - Fork 104
add the option to simply print the md file #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Code looks fine, though one lint error to take care of.
Would you also be able to add a testcase to tests/test_tldr.py
that essentially duplicates test_whole_page
, but just checking that the stdout output matches the contents of tests/data/gem.md
?
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks.
@MasterOdin Do these changes not warrant the creation of a new release, since otherwise these features don't get put into package managers. I'd like to see these in Arch Linux ASAP |
Yes, I was planning on putting together a 2.1.0 release with this PR, and the other commits that had been made since 2.0, sometime in the next few days as my time permitted. |
Good to hear |
See #167