Skip to content

Update video_mode.py #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Update video_mode.py #368

merged 3 commits into from
Nov 8, 2023

Conversation

magicse
Copy link
Contributor

@magicse magicse commented Nov 8, 2023

Added support for video files in MTS format

Added support for video files in MTS format
@magicse magicse mentioned this pull request Nov 8, 2023
@semjon00
Copy link
Collaborator

semjon00 commented Nov 8, 2023

Hello, thank you for contributing!
Did you test that it works with your video(s)?
There is "suffix.lower" in the commit that should be "suffix.lower()" (happens two times).

If this is addressed and code otherwise works I am happy to merge this :)

@magicse
Copy link
Contributor Author

magicse commented Nov 8, 2023

Yes it wotk. I'm currently calculating the depthmap for my videos. thank You.

@magicse
Copy link
Contributor Author

magicse commented Nov 8, 2023

suffix.lower()

It need for all - "if suffix.lower()" to avoid case sensitivity. Because sometime suffix could be like mts or MTS or MP4 or mp4 ))

suffix.lower()
some mistype
@semjon00 semjon00 merged commit b8120b4 into thygate:main Nov 8, 2023
@semjon00
Copy link
Collaborator

semjon00 commented Nov 8, 2023

Merged :)

@magicse There are more things that can be improved in video generation. I would be glad if you submit more code with improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants