Add support for NumPy 1.24.* (pt. 2) #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just after I thought it worked, I noticed another issue. 😅
Somehow my venv ended up in a state where it had transforms3d==0.2.1 installed (which is many years old and does not work with NumPy 1.24.*). I bumped it to 0.4.1. It is the latest version and it worked on my machine. Not sure if it works elsewhere, too, since I could not find where this module is used. So probably requires some testing.
Also, did some refactoring on the dependency installation logic. It could be refactored further (where it installs the exact versions), but does not look necessary to my eye right now.
@thygate
P.S. Thanks for merging the previous MR so fast!