Skip to content

adding sementic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2018
Merged

adding sementic #1

merged 2 commits into from
Dec 11, 2018

Conversation

iamuteti
Copy link
Member

No description provided.

@rwieruch
Copy link
Member

rwieruch commented Dec 11, 2018

Amazing work @iamuteti Thank you so much for it.

A couple of last improvements:

  • If you can, maybe exchange epoch-timeago with date-fns, because the former only has 84 downloads per week, isn't widely known and maybe in a year not well maintained whereas date-fns is a bulletproof library. Maybe distanceInWords can be used as substitute.

  • Add missing CSS: I had to install npm install semantic-ui-css and add it to the src/index.js file:

import React from 'react';
import ReactDOM from 'react-dom';

import 'semantic-ui-css/semantic.min.css';

import './index.css';
import * as serviceWorker from './serviceWorker';

...
  • If it works without additional CSS, have same margin left/right between buttons:

screen shot 2018-12-11 at 20 50 48

  • If it works without additional CSS, put all buttons in one row or at least make two rows out of them whereas the social logins are in the second row. Then the first row has a bottom margin to the second row.

screen shot 2018-12-11 at 20 50 35

  • If it works without additional CSS, put the More button above of the messages, because it fetches older messages, centralize it, and call it maybe "Older Messages".

screen shot 2018-12-11 at 20 51 59

@iamuteti iamuteti merged commit 039bb55 into master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants