Skip to content

IMPORTANT: Deploy Security Rules #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Admin/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const AdminPage = () => (
);

const condition = authUser =>
authUser && authUser.roles.includes(ROLES.ADMIN);
authUser && !!authUser.roles[ROLES.ADMIN];

export default compose(
withEmailVerification,
Expand Down
2 changes: 1 addition & 1 deletion src/components/Firebase/firebase.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class Firebase {

// default empty roles
if (!dbUser.roles) {
dbUser.roles = [];
dbUser.roles = {};
}

// merge auth and db user
Expand Down
42 changes: 8 additions & 34 deletions src/components/Home/index.js
Original file line number Diff line number Diff line change
@@ -1,47 +1,21 @@
import React, { Component } from 'react';
import React from 'react';
import { compose } from 'recompose';

import { withAuthorization, withEmailVerification } from '../Session';
import { withFirebase } from '../Firebase';
import Messages from '../Messages';

class HomePage extends Component {
constructor(props) {
super(props);
const HomePage = () => (
<div>
<h1>Home Page</h1>
<p>The Home Page is accessible by every signed in user.</p>

this.state = {
users: null,
};
}

componentDidMount() {
this.props.firebase.users().on('value', snapshot => {
this.setState({
users: snapshot.val(),
});
});
}

componentWillUnmount() {
this.props.firebase.users().off();
}

render() {
return (
<div>
<h1>Home Page</h1>
<p>The Home Page is accessible by every signed in user.</p>

<Messages users={this.state.users} />
</div>
);
}
}
<Messages />
</div>
);

const condition = authUser => !!authUser;

export default compose(
withFirebase,
withEmailVerification,
withAuthorization(condition),
)(HomePage);
40 changes: 21 additions & 19 deletions src/components/Messages/MessageItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class MessageItem extends Component {
};

render() {
const { message, onRemoveMessage } = this.props;
const { authUser, message, onRemoveMessage } = this.props;
const { editMode, editText } = this.state;

return (
Expand All @@ -41,29 +41,31 @@ class MessageItem extends Component {
/>
) : (
<span>
<strong>
{message.user.username || message.user.userId}
</strong>{' '}
{message.text} {message.editedAt && <span>(Edited)</span>}
<strong>{message.userId}</strong> {message.text}
{message.editedAt && <span>(Edited)</span>}
</span>
)}

{editMode ? (
{authUser.uid === message.userId && (
<span>
<button onClick={this.onSaveEditText}>Save</button>
<button onClick={this.onToggleEditMode}>Reset</button>
</span>
) : (
<button onClick={this.onToggleEditMode}>Edit</button>
)}
{editMode ? (
<span>
<button onClick={this.onSaveEditText}>Save</button>
<button onClick={this.onToggleEditMode}>Reset</button>
</span>
) : (
<button onClick={this.onToggleEditMode}>Edit</button>
)}

{!editMode && (
<button
type="button"
onClick={() => onRemoveMessage(message.uid)}
>
Delete
</button>
{!editMode && (
<button
type="button"
onClick={() => onRemoveMessage(message.uid)}
>
Delete
</button>
)}
</span>
)}
</li>
);
Expand Down
2 changes: 2 additions & 0 deletions src/components/Messages/MessageList.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import React from 'react';
import MessageItem from './MessageItem';

const MessageList = ({
authUser,
messages,
onEditMessage,
onRemoveMessage,
}) => (
<ul>
{messages.map(message => (
<MessageItem
authUser={authUser}
key={message.uid}
message={message}
onEditMessage={onEditMessage}
Expand Down
13 changes: 5 additions & 8 deletions src/components/Messages/Messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ class Messages extends Component {
};

onEditMessage = (message, text) => {
const { uid, ...messageSnapshot } = message;

this.props.firebase.message(message.uid).set({
...message,
...messageSnapshot,
text,
editedAt: this.props.firebase.serverValue.TIMESTAMP,
});
Expand All @@ -86,7 +88,6 @@ class Messages extends Component {
};

render() {
const { users } = this.props;
const { text, messages, loading } = this.state;

return (
Expand All @@ -103,12 +104,8 @@ class Messages extends Component {

{messages && (
<MessageList
messages={messages.map(message => ({
...message,
user: users
? users[message.userId]
: { userId: message.userId },
}))}
authUser={authUser}
messages={messages}
onEditMessage={this.onEditMessage}
onRemoveMessage={this.onRemoveMessage}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Navigation/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const NavigationAuth = ({ authUser }) => (
<li>
<Link to={ROUTES.ACCOUNT}>Account</Link>
</li>
{authUser.roles.includes(ROLES.ADMIN) && (
{!!authUser.roles[ROLES.ADMIN] && (
<li>
<Link to={ROUTES.ADMIN}>Admin</Link>
</li>
Expand Down
6 changes: 3 additions & 3 deletions src/components/SignIn/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class SignInGoogleBase extends Component {
return this.props.firebase.user(socialAuthUser.user.uid).set({
username: socialAuthUser.user.displayName,
email: socialAuthUser.user.email,
roles: [],
roles: {},
});
})
.then(() => {
Expand Down Expand Up @@ -154,7 +154,7 @@ class SignInFacebookBase extends Component {
return this.props.firebase.user(socialAuthUser.user.uid).set({
username: socialAuthUser.additionalUserInfo.profile.name,
email: socialAuthUser.additionalUserInfo.profile.email,
roles: [],
roles: {},
});
})
.then(() => {
Expand Down Expand Up @@ -200,7 +200,7 @@ class SignInTwitterBase extends Component {
return this.props.firebase.user(socialAuthUser.user.uid).set({
username: socialAuthUser.additionalUserInfo.profile.name,
email: socialAuthUser.additionalUserInfo.profile.email,
roles: [],
roles: {},
});
})
.then(() => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/SignUp/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ class SignUpFormBase extends Component {

onSubmit = event => {
const { username, email, passwordOne, isAdmin } = this.state;
const roles = [];
const roles = {};

if (isAdmin) {
roles.push(ROLES.ADMIN);
roles[ROLES.ADMIN] = ROLES.ADMIN;
}

this.props.firebase
Expand Down