Skip to content

feat: use getSuggestedQuery from @testing-library/dom #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2020
Merged

feat: use getSuggestedQuery from @testing-library/dom #113

merged 3 commits into from
Jun 9, 2020

Conversation

marcosvega91
Copy link
Member

closes #112

@smeijer
Copy link
Member

smeijer commented Jun 8, 2020

@marcosvega91, is it just broken, or weren't you finished yet? 😇

@marcosvega91
Copy link
Member Author

What is the problem?

@smeijer
Copy link
Member

smeijer commented Jun 9, 2020

Selecting elements, now renders errors?

ezgif-2-0d0fed03a885

@marcosvega91
Copy link
Member Author

fixed :)

@smeijer smeijer changed the title feat: use DTL getSuggestedQuery feat: use getSuggestedQuery from @testing-library/dom Jun 9, 2020
@smeijer smeijer merged commit c50b039 into testing-library:develop Jun 9, 2020
@marcosvega91 marcosvega91 deleted the feature/use_getSuggestedQuery branch June 9, 2020 10:09
@smeijer smeijer mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcosvega91 marcosvega91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use the official testing-lib getSuggestedQuery for query advise
2 participants
@marcosvega91 @smeijer