[findByLabelText] Adds a bad example using for w/ a non-form element #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmilajesupaul
force-pushed
the
patch-1
branch
from
936b8f4 to
686842c
Compare
This came up at my work today. An engineer thought that a `for` attr on a `<label>` along with a related `<section>` `id` can be queried by `findByLabelText`. But really, we end up with this error: ``` Timed out retrying: Found a label with the text of: Photos, however no form control was found associated to that label. Make sure you're using the "for" attribute or "aria-labelledby" attribute correctly. ``` I think making that explicit in the docs would avoid future confusion.
sharmilajesupaul
force-pushed
the
patch-1
branch
from
686842c to
db4db90
Compare
|
@all-contributors please add @sharmilajesupaul for docs |
|
I've put up a pull request to add @sharmilajesupaul! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up at my work today.
An engineer thought that a
forattr on a<label>along with a related<section>idcan be queried byfindByLabelText.But really, this is not semantically correct and we end up with this error:
I think making that explicit in the docs would avoid future confusion.