Skip to content

fix(a11y): underline links in a text block as pur WCAG 2.0 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

brianlu2610
Copy link
Contributor

As per WCAG 2.0 guidelines, links must be visually distinguishable from normal text when they are in a text block without relying on color. This PR remediates that issue for the "Help" page.

Current Help Page in production: https://testing-library.com/help

https://dequeuniversity.com/rules/axe/4.10/link-in-text-block?application=AxeChrome
https://www.w3.org/TR/WCAG20-TECHS/F73.html

image

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 2637f22
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/673273cf4d7dfc0008f9a7b7
😎 Deploy Preview https://deploy-preview-1449--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatanBobi
Copy link
Member

Thanks :)
Shouldn't we just add the underline to every anchor element? Why did you choose to do it for a specific class? We can resolve this issue for the entire site that way.

@brianlu2610
Copy link
Contributor Author

We can definitely do that.

I chose to add a class because not all anchor elements need to be permanently underlined for the site to be accessible. ONLY those surrounded by a block of text would require it. Anchor elements by themselves only require to be underlined on hover, which is already default behavior.

I don't think there is any harm in underlining every link in the docs, but wanted to keep that optional.

@MatanBobi
Copy link
Member

Got you. Thanks! :)

@MatanBobi MatanBobi merged commit 6015c05 into testing-library:main Nov 23, 2024
4 checks passed
@MatanBobi
Copy link
Member

@all-contributors please add @brianlu2610 for code :)

Copy link
Contributor

@MatanBobi

I've put up a pull request to add @brianlu2610! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants