Skip to content

chore: Improve docs with removing misleading statement on query API i… #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

vadimshvetsov
Copy link
Contributor

Since in new versions of @testing-library/cypress we don't have queryBy and queryAllBy APIs its reasonable to remove them from docs.

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 7adc312
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/6560e6e1a687cf000860203d
😎 Deploy Preview https://deploy-preview-1344--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it has been like that since 2020, that's sad for us.
Thanks for picking it up!

@MatanBobi MatanBobi merged commit 7efbe46 into testing-library:main Nov 26, 2023
@MatanBobi
Copy link
Member

@all-contributors please add @vadimshvetsov for docs :)

Copy link
Contributor

@MatanBobi

I've put up a pull request to add @vadimshvetsov! 🎉

@testing-library testing-library deleted a comment from allcontributors bot May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants