Skip to content

fix: userEvent utility example code #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2023
Merged

fix: userEvent utility example code #1309

merged 1 commit into from
Oct 7, 2023

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Sep 17, 2023 •
edited
Loading

I fixed userEvent to .setup() instead of utilizing it directly.

Thank you for checking it out and providing feedback.

@netlify
Copy link

netlify bot commented Sep 17, 2023 •
edited
Loading

✅ Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 6426cdc
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/6506b3f031fc6f000803c1f7
😎 Deploy Preview https://deploy-preview-1309--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ssi02014
Copy link
Contributor Author

@timdeschryver 👋
I would appreciate it if you could take a look at that pull request!

timdeschryver
timdeschryver approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@timdeschryver timdeschryver merged commit 22cf9b4 into testing-library:main Oct 7, 2023
@ssi02014 ssi02014 deleted the userEvent/utility branch October 7, 2023 13:31
@ssi02014 ssi02014 changed the title refac: refactoring userEvent utility example code fix: userEvent utility example code Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssi02014 @timdeschryver