Skip to content

feat: add FAQ for svelte-testing-library #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

yanick
Copy link
Contributor

@yanick yanick commented Jul 7, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 1c484be
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/64a828565a3a4e0008abc1b2
😎 Deploy Preview https://deploy-preview-1268--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatanBobi
Copy link
Member

MatanBobi commented Jul 8, 2023

Hi @yanick! Thanks for taking the time to open this one.
I'm not sure this is worth an FAQ page since it's probably data that can be found in an issue and is quite specific to a use case of uploading and not generic to the usage of the library.
I'm closing this, thanks again and sorry.

@MatanBobi MatanBobi closed this Jul 8, 2023
@yanick
Copy link
Contributor Author

yanick commented Jul 8, 2023 via email

@MatanBobi
Copy link
Member

A simple search in google will probably raise the answer. The downside to putting something in the docs is that we need to maintain it and keep it updated, at the moment it's only one FAQ, but if we don't see a reason to create an FAQ besides that, I don't think we'd want to burden of maintaining it :)

@yanick
Copy link
Contributor Author

yanick commented Jul 9, 2023

I would expect that the maintainer of svelte-testing-library has the job to keep the documention up-to-date. And that'd be me.

But okay, FAQ in the project's README it is. 🤷

@MatanBobi MatanBobi reopened this Jul 9, 2023
@MatanBobi
Copy link
Member

MatanBobi commented Jul 9, 2023

I would expect that the maintainer of svelte-testing-library has the job to keep the documention up-to-date. And that'd be me.

But okay, FAQ in the project's README it is. 🤷

Sorry, I missed the part that you're maintaining it :)
If you're good with maintaining this area too, I have no objections to push this.

@yanick
Copy link
Contributor Author

yanick commented Jul 9, 2023

If you're good with maintaining this area too, I have no objections to push this.

That was my expectation, yup. :-)

@MatanBobi MatanBobi merged commit 6bc2f51 into testing-library:main Jul 9, 2023
@MatanBobi
Copy link
Member

@all-contributors please add @yanick for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @yanick! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants