Skip to content

Fix getByAltText examples #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

Fix getByAltText examples #117

merged 2 commits into from
May 22, 2019

Conversation

bjohn465
Copy link
Contributor

Fixes #116

I replaced /incredibles.*png$/i with 'Incredibles 2 Poster', which should match the alt attribute in the example markup.

kentcdodds
kentcdodds reviewed May 22, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we use regex still? It's more resilient to changes in the content.

@bjohn465
Copy link
Contributor Author

Will do

kentcdodds
kentcdodds approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@kentcdodds kentcdodds merged commit 1f971a4 into testing-library:master May 22, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @bjohn465 for docs

@allcontributors allcontributors bot mentioned this pull request May 22, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @bjohn465! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ByAltText examples seem incorrect
2 participants
@bjohn465 @kentcdodds