Added example for container #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be merged after testing-library/svelte-testing-library#24 will be published
benmonro
requested changes
May 18, 2019
docs/svelte-testing-library/intro.md
Outdated
| @@ -58,13 +58,14 @@ describe('App', () => { | |||
| }) | |||
|
|
|||
| test('should change button text after click', async () => { | |||
| const { getByText } = render(App, { props: { name: 'world' } }) | |||
| const { getByText, container } = render(App, { props: { name: 'world' } }) | |||
There was a problem hiding this comment.
@ematipico actually would you mind adding this in a separate section? for this basic example, I'd prefer to keep it as is, and then have 'containers' be listed below.
There was a problem hiding this comment.
Suggested change
| const { getByText, container } = render(App, { props: { name: 'world' } }) | |
| const { getByText } = render(App, { props: { name: 'world' } }) |
|
|
||
| fireEvent.click(getByText('Button Text')) | ||
|
|
||
| const button = await waitForElement(() => getByText('Button Clicked')) | ||
|
|
||
| expect(button).toBeInTheDocument() | ||
| expect(container.firstChild).toMatchSnapshot() |
There was a problem hiding this comment.
Suggested change
| expect(container.firstChild).toMatchSnapshot() |
benmonro
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after testing-library/svelte-testing-library#24 will be published
cc @benmonro