Skip to content

fix(TS): Add missing getAll and queryAll functions to TS definitions #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018

Conversation

pbomb
Copy link
Collaborator

@pbomb pbomb commented May 18, 2018

What:

Adds missing TypeScript definitions for the getAll* and queryAll* functions. Also adds type definition for re-exported getQueriesForElement function.

Why:

These additions more accurately reflect what the library does and they're helpful. I found that I could get rid of some calls to querySelectorAll in favor of queryAllByTestId in my tests, which was more convenient.

How:

Imported and reused the TS definitions from dom-testing-library to bind the get/query functions to the dom element.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@kentcdodds kentcdodds merged commit fc09a99 into testing-library:master May 18, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pbomb
Copy link
Collaborator Author

pbomb commented May 18, 2018

Thanks, Kent!

@pbomb pbomb deleted the getAll-queryAll branch May 18, 2018 14:28
@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@pbomb
Copy link
Collaborator Author

pbomb commented May 18, 2018

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants