fix(TS): Add missing getAll and queryAll functions to TS definitions #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds missing TypeScript definitions for the getAll* and queryAll* functions. Also adds type definition for re-exported
getQueriesForElement
function.Why:
These additions more accurately reflect what the library does and they're helpful. I found that I could get rid of some calls to
querySelectorAll
in favor ofqueryAllByTestId
in my tests, which was more convenient.How:
Imported and reused the TS definitions from dom-testing-library to bind the get/query functions to the dom element.
Checklist: