Skip to content

docs(readme): Add install command for yarn #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

Ishaan28malik
Copy link
Contributor

@Ishaan28malik Ishaan28malik commented Apr 21, 2020

What: Added about the yarn installation process.

Why: For developers who run the build using yarn

How: Adding the yarn add bash command.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@Ishaan28malik
Copy link
Contributor Author

@afontcu Please review this.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4811544:

Sandbox Source
serene-neumann-4ez10 Configuration
interesting-hofstadter-c9jyi Configuration

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #645   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          103       103           
  Branches        15        15           
=========================================
  Hits           103       103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1232e1f...4811544. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including yarn. Would appreciate it if you could answer the questions below.

Copy link
Contributor Author

@Ishaan28malik Ishaan28malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon I have made the required changes

Copy link
Contributor Author

@Ishaan28malik Ishaan28malik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the final changes.
@eps1lon does this looks good to you?

@Ishaan28malik
Copy link
Contributor Author

@eps1lon do I still need to make any changes?

@Ishaan28malik Ishaan28malik requested a review from eps1lon April 24, 2020 07:49
@eps1lon eps1lon added documentation A docs improvement is needed. and removed documentation A docs improvement is needed. labels Apr 24, 2020
@eps1lon eps1lon changed the title Update README.md docs(readme): Add install command for yarn Apr 24, 2020
@eps1lon eps1lon merged commit d6310a2 into testing-library:master Apr 24, 2020
@eps1lon
Copy link
Member

eps1lon commented Apr 24, 2020

@all-contributors add @Ishaan28malik for docs

@eps1lon
Copy link
Member

eps1lon commented Apr 24, 2020

@Ishaan28malik Thanks!

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @Ishaan28malik! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Ishaan28malik
Copy link
Contributor Author

@kentcdodds that's great to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants