Skip to content

test: Build in CodeSandbox CI #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 30, 2019

What:

Build package in PRs for codesandbox

Closes #533

Why:

Integration testing, shareable live playground of new features etc

How:

https://twitter.com/codesandbox/status/1181184975460282368

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@eps1lon
Copy link
Member Author

eps1lon commented Oct 30, 2019

Repository has to be whitelisted first (I guess because you can't have private apps on GitHub). I DMed Ives.

@MichaelDeBoey
Copy link
Member

CodeSandbox CI is public now 🙂

https://codesandbox.io/post/codesandbox-ci-embeds

@eps1lon eps1lon force-pushed the test/codesandbox-ci branch from c94eb62 to fc2f6a2 Compare November 15, 2019 14:14
@eps1lon
Copy link
Member Author

eps1lon commented Nov 15, 2019

Huh, weird. @kentcdodds Could you check/reset the permissions again before I message Ives?

@kentcdodds
Copy link
Member

Permissions are good 👍

@eps1lon eps1lon mentioned this pull request Nov 17, 2019
1 task
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5a20a8:

Sandbox Source
bold-hooks-st9l9 Configuration
react-testing-library-examples Configuration

@lbogdan
Copy link

lbogdan commented Nov 17, 2019

Hey! We're now white-listing all newly added repositories, but we somehow omitted to also white-list the ones added before the official release. 🙂 I just did it now, and replayed the GitHub webhook, which triggered the build.

@eps1lon eps1lon changed the title test: Build in codesandbox ci test: Build in CodeSandbox CI Nov 17, 2019
@kentcdodds
Copy link
Member

Super! Is this ready to go @eps1lon?

@eps1lon
Copy link
Member Author

eps1lon commented Nov 17, 2019

Super! Is this ready to go @eps1lon?

Oh right. Forget to mark as ready to merge. This is good to go.

@kentcdodds kentcdodds merged commit 14670de into testing-library:master Nov 17, 2019
@eps1lon eps1lon deleted the test/codesandbox-ci branch November 17, 2019 17:35
@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants