Skip to content

Update README.md #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Update README.md #461

merged 1 commit into from
Aug 21, 2019

Conversation

hanorine
Copy link
Contributor

Removing import '@testing-library/react/cleanup-after-each'; due to deprecation.

What: Example code on main README.md

Why: Deprecated and confusing.

How: Removed directly from file.

Checklist:

  • Documentation added to the
    docs site"N/A"
  • Tests "N/A"
  • Typescript definitions updated "N/A"
  • Ready to be merged "N/A"

Removing `import '@testing-library/react/cleanup-after-each'; ` due to deprecation.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@kentcdodds kentcdodds merged commit dca5d9a into testing-library:master Aug 21, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @JaysQubeXon for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @JaysQubeXon! 🎉

@hanorine
Copy link
Contributor Author

Glad I could be of some help!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants