feat: add dont-cleanup-after-each.js #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a simple file that sets the RTL_SKIP_AUTO_CLEANUP environment variable so that RTL doesn't setup automatic cleanup. This makes it easier for folks who don't want to write their tests in an isolated way. It's totally not recommended, but it will hopefully reduce pain while people migrate from one testing style to another.
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 90 90
Branches 13 13
=====================================
Hits 90 90Continue to review full report at Codecov.
|
|
I'd love someone else to merge this. I've been a bit merge-happy recently 😅 |
alexkrolick
reviewed
Aug 10, 2019
| @@ -0,0 +1 @@ | |||
| process.env.RTL_SKIP_AUTO_CLEANUP = true | |||
There was a problem hiding this comment.
Does this need to be browser-safe?
There was a problem hiding this comment.
I don't think it is worth the effort.
alexkrolick
approved these changes
Aug 10, 2019
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: add dont-cleanup-after-each.js
Why:
This makes it easier for folks who don't want to write their tests in an isolated way. It's totally not recommended, but it will hopefully reduce pain while people migrate from one testing style to another.
How:
This is just a simple file that sets the RTL_SKIP_AUTO_CLEANUP environment variable so that RTL doesn't setup automatic cleanup.
Checklist:
docs site done
I decided to do this after reading #430 (comment)