Skip to content

ci: test with node 8, 10, and 12 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianMurphy
Copy link
Contributor

What:

Tests library across node versions

Why:

To ensure library works on all Node LTS releases

How:

Adding a build matrix to travis ci.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kentcdodds kentcdodds merged commit 06ce496 into testing-library:master Jul 23, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @ChristianMurphy for infra

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @ChristianMurphy! 🎉

@ChristianMurphy ChristianMurphy deleted the test/multiple-node-versions branch July 23, 2019 16:44
@kentcdodds
Copy link
Member

🎉 This PR is included in version 8.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants