Skip to content

Pr/docs react intl #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

viniciusavieira
Copy link
Contributor

What:
Add example of React-Intl integration

Why:
Because there is no example of it.

How:
Create an example in the examples folder, but to add this example I had to add intl and react-intl as devDependencies, since both are used on the test.

Checklist:

  • Documentation added to the docs site
  • [ X ] Tests
  • Typescript definitions updated
  • [ X ] Ready to be merged
  • [ X ] Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you!

@kentcdodds kentcdodds merged commit 4302cdd into testing-library:master Mar 20, 2019
@viniciusavieira viniciusavieira deleted the pr/docs-react-intl branch March 20, 2019 17:34
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants