Declare "module" in package.json #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exposes the ESM build of react-testing-library.
kentcdodds
approved these changes
Feb 6, 2019
|
Thanks! |
|
🎉 This PR is included in version 5.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This change exposes the ESM version of the build, in the same fashion that the ES modules build is declared in
dom-testing-library.Why:
The ESM build is currently generated and distributed upon publish, though it is not exposed via
package.json. My admittedly selfish use case for this is in having better heuristics around some linting rules (namelyimport/named).How:
• Added the
modulefield topackage.json, pointing it at the path of the built artifactChecklist:
&c.:
Thanks for this library–it's great! Let me know if there's anything I overlooked or you would like to see changed.