fix(TS): add queries typings #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Jan 4, 2019
|
Thanks! |
|
🎉 This PR is included in version 5.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
joeporpeglia
reviewed
Jan 4, 2019
|
|
||
| export * from 'dom-testing-library' | ||
|
|
||
| type GetsAndQueries = ReturnType<typeof getQueriesForElement> | ||
| interface Query extends Function { | ||
| (container: HTMLElement, ...args): HTMLElement[] | HTMLElement | null |
There was a problem hiding this comment.
@chochihim @kentcdodds heads up, the ...args expression here causes TS builds to fail when --noImplicitAny is set.
Type error: Rest parameter 'args' implicitly has an 'any[]' type. TS7019
4 |
5 | interface Query extends Function {
> 6 | (container: HTMLElement, ...args): HTMLElement[] | HTMLElement | null
| ^
7 | }
8 |
9 | interface Queries {
There was a problem hiding this comment.
😬
Could you please open a PR to fix this @joeporpeglia.
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add typings for queries in RenderOptions
Why: It's missing. Also in a project I need to add some custom queries.
How:
Checklist:
The implementation is trickier than I thought. Any comment is appreciated. Also
QueryandQueriesshould probably be declared indom-testing-library. I can create another PR once the implementation of this PR is accepted.