Skip to content

flushEffects() typings #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RiledUpCrow
Copy link

What: I've added typings for flushEffects function.

Why: I know it's an experimental feature and you're looking for a better solution, but as long as this function is actually exported it will be good to have typings for it.

How: I've taken the comment for the function directly from README.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kentcdodds kentcdodds merged commit f6cfa86 into testing-library:master Nov 28, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RiledUpCrow RiledUpCrow deleted the flush-effects-typings branch November 29, 2018 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants