feat: add (experimental) flushEffects to prepare for hooks #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 24 25 +1
Branches 4 4
=====================================
+ Hits 24 25 +1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
ci: 🎡 run node 13 in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: add (experimental)
flushEffectsAPIWhy: to prepare for hooks
The more that I've thought it over, the more I'm thinking it may actually be better to force people to flush effects intentionally (even if it is a little less ergonomic). In any case, I think it's not a bad thing to have.
How:
When
ReactDOM.renderis called, all in-flight effects are run synchronously (at least with the current implementation of hooks). If that ever changes, we can update theflushEffectsimplementation, but this allows people to test their hooks as they experiment with the new hooks API.Checklist: