Update README.md #221
Merged
Update README.md #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions missed the `options` argument, I got confused at the beginning and I moved back and forth from `dom-testing-library` and `react-testing-library` to understand the differences...
kentcdodds
reviewed
Nov 14, 2018
Added the complete typings to the description except for `ignore = 'script, style',`. I skipped the `ignore` option to be aligned with the `dom-testing-library`
|
Done, I followed the same signing of the Let me know what do you think or if you prefer I think better at changing the readme to make it "better" |
kentcdodds
approved these changes
Nov 14, 2018
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
…with-text fix: 🐛 type supports fields with previous text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've aligned the documented signature of some functions in the README
I made that because I got confused at the beginning and I took some time to understand that they were just some examples (and not a real documentation).