Skip to content

Update dom-testing-library #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Update dom-testing-library #190

merged 1 commit into from
Oct 3, 2018

Conversation

gnapse
Copy link
Member

@gnapse gnapse commented Oct 3, 2018

What:

Upgrade dom-testing-library dependency version.

Why:

Because there are new features (e.g. getBySelectText) that were released in dom-testing-library very recently, and are not yet available in react-testing-library.

How:

By editing package.json

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version range should allow the latest dom-testing-library to be installed, but forcing it is good too 👍

@kentcdodds kentcdodds merged commit 2a11275 into testing-library:master Oct 3, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnapse
Copy link
Member Author

gnapse commented Oct 3, 2018

^3.1.0 wasn't giving me 3.8 though. Anyway, thanks!

@gnapse gnapse deleted the patch-2 branch October 3, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants