-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add React Native FAQ. #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d72deae
to
090784d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you can just fix the prettier issue that'd be great!
Also, if you'd like to add James to the contributors table that'd be super :) Thanks!
README.md
Outdated
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | ||
|
||
- [Installation](#installation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this has something to do with you having an old version of prettier. Could you make sure that you have the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll get this done in the next few hours.
090784d
to
8fe7384
Compare
Thanks for going through the work to add it to the docs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🎉 This PR is included in version 5.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Add some documentation regarding usage with React Native.
Why:
First step to tackling a long(ish) standing issue regarding this.
How:
Added an FAQ point discussing how one might go about using this library with React Native. Main credit to @jlongster here. I just corroborated the findings 🙂
Checklist: