Skip to content

adding myself as contributor #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

adding myself as contributor #185

merged 1 commit into from
Sep 19, 2018

Conversation

srprkr
Copy link
Contributor

@srprkr srprkr commented Sep 19, 2018

What:

Why:

How:

Checklist:

  • [x ] Documentation
  • [ x] Tests
  • [x ] Ready to be merged
  • [x ] Added myself to contributors table

Thank you. Have a great day.

kentcdodds
kentcdodds approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍

@kentcdodds kentcdodds merged commit 9c8c933 into testing-library:master Sep 19, 2018
@srprkr srprkr deleted the pr/contributor-update branch September 19, 2018 15:03
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
@klujanrosas
feat(type): handle maxLength for textinput/textarea (testing-library#185
259fb3a 
)

* feat(type): handle maxLength for textinput/textarea

* test(type): can't write past maxLength

* feat: fire keyup/keypress/keydown events

* test: keydown/keypress/keydown events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srprkr @kentcdodds