Added jest.mock line remaining in the main example #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, I was struggling to mock the axios response following the main example here. After hours searching, I've discovered that I needed to mock the axios to be able to access the mock functions inside of it. So, I've added a small line of code to not break the example and stop new learners.
kentcdodds
reviewed
Sep 18, 2018
| @@ -272,34 +276,6 @@ module.exports = { | |||
| } | |||
| ``` | |||
|
|
|||
|
|
|||
| #### Export Issue with Babel Versions Lower Than 7 | |||
There was a problem hiding this comment.
Could you rebase your PR (or just make a new one) that doesn't remove this?
There was a problem hiding this comment.
Oh! Ok! I'll create another one!
kentcdodds
reviewed
Sep 18, 2018
| @@ -89,6 +89,10 @@ import 'jest-dom/extend-expect' | |||
| import axiosMock from 'axios' // the mock lives in a __mocks__ directory | |||
| import Fetch from '../fetch' // see the tests for a full implementation | |||
|
|
|||
| // Once we mock the module we can provide a mockResolvedValueOnce for .get | |||
| // that returns the fake data we want our test to assert against. | |||
| jest.mock('axios'); | |||
There was a problem hiding this comment.
This isn't necessary because the comment on line 89 indicates that there's a mock in the __mocks__ directory.
kentcdodds
requested changes
Sep 18, 2018
|
Would you like to change this PR to add a link to the jest docs about the |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Well, I was struggling to mock the axios response following the main example here. After hours searching it, I've discovered that I needed to mock the axios to be able to access the mock functions inside of it.
Why:
I've added a small line of code to not break the example and stop new learners.
How:
I followed the example inside the jest documentation.
Checklist: