fix: add support for react portal elements #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Components like modals, dialogs, hovercards, tooltips etc use React portals to render them into
document.body
. Testing utilities can query only on the container and this cannot do testing in such components.Why:
This fix is necessary to test components that uses react portals.
How:
When using
renderIntoComponent
, instead of exposing test utilities for container, we do it fordocument.body
which contains the container.Checklist: