-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: necessary api changes for React 19 compatibility #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ddf9df9
add `renderWithoutAct` helper
phryneas e8616b3
painful progress
phryneas 5ff5420
make render async to wait for first render
phryneas c124751
all tests passing
phryneas 20ef3eb
more tweaking
phryneas b086f98
fix type
phryneas 6fb6fb1
also wrap asyncWrapper
phryneas 8474b54
export `RenderWithoutActAsync` type
phryneas d926b40
build legacy root in React 16/17
phryneas 1ad050f
disable act with confidence
phryneas 9ef55bb
don't auto-disable act, throw error instead
phryneas 2c5b29e
adjust imports
phryneas 69a4c4b
wait a bunch longer so react doesn't batch
phryneas c064440
add comment
phryneas 932f938
guard in tests against accidental `IS_REACT_ACT_ENVIRONMENT`
phryneas 451d67a
drain the microtask queue before returning from `peekRender`
phryneas 53d9f45
directly import from `@testing-library/dom` where possible
phryneas 32daf10
move `useWithoutAct` into `disableActEnvironment`, reduce api size
phryneas 084b691
keep `writable` at cleanup
phryneas 563b934
early bailout in `cleanup`
phryneas 0e9d9d7
keep `renderWithoutAct` private
phryneas 94f35e5
`renderToRenderStream` also should be async
phryneas 262ceba
make `rerender` wait for the render and return `Promise<void>`
phryneas c09b997
update README
phryneas 200d9d2
remove unused type
phryneas 0cf8f41
undo `renderToRenderStream` changes
phryneas 20601bc
add type export back
phryneas e1cb39d
update type
phryneas fab8705
guard against sync rerenders
phryneas 04c222d
remove `renderToRenderStream`
phryneas 324ae88
add lint pr job
phryneas e1eae04
avoid uncaught promise rejection in test
phryneas 7e9ac02
Merge branch 'main' into pr/noActRender
phryneas 7ea9591
run tests with React 19 RC1
phryneas 7ede425
use `use` over the shim when available
phryneas f3fb67d
Apply suggestions from code review
phryneas b0d022f
adjust import
phryneas 4d2345b
review suggestions
phryneas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.