-
-
Notifications
You must be signed in to change notification settings - Fork 44
Update React and React Native dependencies #61
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 20
Lines ? 266
Branches ? 67
=======================================
Hits ? 266
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
Hmm all of the stuff for async act (which was written by Sunil from the React team) was ported over from React Testing Library, so the async render function shouldn't be necessary 🤔The only thing we were waiting for was a version of React Native that supported React 16.9. Just bumping the version of React Native should resolve these warnings. I'd rather not take any sort of approach like this in any case, because that would knock our API out of parity with the rest of Testing Library, which is something we won't want to do. Can we try just bumping the version of React and running the tests to verify everything still works and the async act warnings go away? |
Actually, @threepointone if you have a chance can you weigh in on whether or not we'll need to do something like this if we've already implemented the same logic as you wrote for React Testing Library? |
I've been using react-native 0.61 in my project and using Since Unless I've horribly misunderstood something 😃 Just updating the dev dependencies to the latest (0.61.1 and 16.9.0 for |
I've just reverted all the non-update commits so the only changes left are the library updates 👍 |
Upon further review, we might actually need the typing updates. (at least the updates to We should be able to do something similar to @testing-library/react to make it backwards compatible:
|
@jeffreyffs let's do that in a follow up. I want to go ahead and get this one in. @allcontributors please add @SophieAu for code. Thanks for your help! |
I've put up a pull request to add @SophieAu! 🎉 |
🎉 This PR is included in version 4.0.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Updated the React and React Native dependencies in the
package.json
Why:
This allows us to use async act which is new in
react-test-renderer 16.9.0
How:
-/-
Checklist:
docs site
I'm not 100% sure about the way I'm differentiating between async and sync act calls. My first thought was simply exposing two different functions:
render
andasyncRender
andfireEvent
and asyncFireEvent`. I'm just wondering if there are more elegant ways to handle this....Tests are still missing since they're dependent on what the actual implementation is going to be. Same with updates to the docs