Skip to content
This repository was archived by the owner on Jul 30, 2020. It is now read-only.
This repository was archived by the owner on Jul 30, 2020. It is now read-only.

TS error after update TS to version 3.7 #80

Closed
@serzmerz

Description

@serzmerz
  • native-testing-library version: 5.0.0
  • typescript version: 3.7.2

What you did:

Upgrade ts to version 3.7.2

What happened:

I faced with error:

node_modules/@testing-library/react-native/typings/query-helpers.d.ts:1:10 - error TS2440: Import declaration conflicts with local declaration of 'ReactTestInstance'.

1 import { ReactTestInstance } from 'react-test-renderer';
           ~~~~~~~~~~~~~~~~~


Found 1 error.

It is related to change in TS 3.7:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict

Problem description:

In ts 3.7 local and imported declarations now conflict, so we need to extend and rename types with the same name.

Suggested solution:

I suggest to rename and extend interfaces in file query-helpers.d.ts
Actually, I found this PR: #79
could you merge it?

Can you help us fix this issue by submitting a pull request?

Yes, but PR is exist #79.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions