test: refactor @marko/testing-library tests
#582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
previously approved these changes
May 11, 2022
MichaelDeBoey
force-pushed
the
refactor-marko-tests
branch
from
bea1950 to
c78beb5
Compare
|
What happened with the previous review? 🤔 |
timdeschryver
approved these changes
May 11, 2022
|
I think more code got refactored 😁 |
|
All should be fine now 🙈 |
Exactly. Good work @MichaelDeBoey. |
@PrashantAshok I just wanted to provide context & let you know about this PR, that's all 🤷♂️ |
Belco90
approved these changes
May 12, 2022
This was referenced May 12, 2022
Merged
|
🎉 This PR is included in version 5.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #572.
All rules that are included in the
markoconfig should test that the rule is working for@marko/testing-libraryas well.To do so for #572, @PrashantAshok copied over some tests and replaced the import, but didn't include tests for the following rules:
await-async-utilsno-promise-in-fire-eventno-render-in-setupno-wait-for-snapshotprefer-find-byThe way I presented in the PR, is to map over an array of the already tested framework +
@marko/testing-library.This PR is only doing that.
I'll create a separate PR to test against all testing framework that the rules support.